[crac] RFR: PID adjustment on checkpoint [v10]

[Roman Marchenko]

On Wed, 28 Jun 2023 11:57:56 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added  FIXME for further steps
>
> src/java.base/share/native/launcher/main.c line 213:
> 
>> 211: static void spin_last_pid(int pid) {
>> 212:     const int MaxSpinCount = pid < 1000 ? 1000 : pid;
>> 213:     for (int child = fork(), prev = 0, cnt = MaxSpinCount; child < pid; child = fork(), --cnt) {
> 
> Since waitpid is called only if `child < pid`, does this mean the last child that satisfy pid requirement is left unwaited?

Yes, you're correct. 
Do you think it's potentially dangerous or consumes resources?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1246915249