[crac] RFR: PID adjustment on checkpoint [v13]

[Roman Marchenko]

On Thu, 29 Jun 2023 16:12:21 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 22 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:crac' into pid-adjustment
>>  - Added test case
>>  - Merge branch 'pid1-tests' into pid-adjustment
>>  - Implemented running command in container directly
>>  - Added  FIXME for further steps
>>  - Fixing review comments
>>  - Fixing review comments
>>  - Revert "Now CracMinPid option must be set explicitly to adjust PID"
>>    
>>    This reverts commit b3d66800d6ea441fb86498fdbb229400747eb44f.
>>  - Now CracMinPid option must be set explicitly to adjust PID
>>  - Adapting tests
>>  - ... and 12 more: https://git.openjdk.org/crac/compare/3b3ab11d...b164f67b
>
> test/jdk/jdk/crac/ContainerPidAdjustmentTest.java line 81:
> 
>> 79: 
>> 80:     @Override
>> 81:     // FIXME: need to add a test for default values, for Java's PID==1.
> 
> Is it still valid?

No, I'll remove this.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1246916170