[crac] RFR: Wake up all TIMED_WAITING threads after restore [v4]
Radim Vansa
rvansa at openjdk.org
Fri Jun 30 08:08:16 UTC 2023
> This is a fix for an issue found by @jankratochvil when testing #53: Threads that enter sleep or timed parking use absolute monotonic time for pthread_cond_timedwait(). When the monotonic time changes during C/R we need to wake all threads to readjust the timeout to the new absolute time.
>
> This introduces effectively a spurious wakeup; this is permitted for all the uses of pthread_cond_timedwait. Implementation either handles that transparently or propagates the wakeup to Java.
>
> This commit does not handle timed waiting in non-Java threads other than WatcherThread.
Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge remote-tracking branch 'origin/crac' into timed_wait
- Don't use OS thread state
- Inline Thread::interrupt
- Use Threads::java_threads_do, check spurious timeouts
- Wake up all TIMED_WAITING threads after restore
Threads that enter sleep or timed parking use absolute monotonic time
for pthread_cond_wait(). The specification permits spurious wakeups;
implementation either handles that transparently or propagates
the wakeup.
This commit does not handle timed waiting in non-Java threads other than
WatcherThread.
-------------
Changes:
- all: https://git.openjdk.org/crac/pull/85/files
- new: https://git.openjdk.org/crac/pull/85/files/df9ed092..4ddd1f05
Webrevs:
- full: https://webrevs.openjdk.org/?repo=crac&pr=85&range=03
- incr: https://webrevs.openjdk.org/?repo=crac&pr=85&range=02-03
Stats: 1081 lines in 17 files changed: 1047 ins; 10 del; 24 mod
Patch: https://git.openjdk.org/crac/pull/85.diff
Fetch: git fetch https://git.openjdk.org/crac.git pull/85/head:pull/85
PR: https://git.openjdk.org/crac/pull/85
More information about the crac-dev
mailing list