[crac] RFR: Convert CRaC tests from shell scripts to Java
Radim Vansa
duke at openjdk.org
Thu Mar 2 16:53:55 UTC 2023
On Tue, 28 Feb 2023 18:35:27 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Right now this is a draft as it builds on top of https://github.com/openjdk/crac/pull/47
>>
>> Please see `CracTest` javadoc for detailed info.
>
> This looks very nice! While this is a draft, what should be especially looked? As an approach, this is what these tests were missing!
@AntonKozlov I've merged with recent `crac`, also updating the tests integrated in the meantime and adding more goodies for Docker.
The main and args parameters to CracBuilder now use test defaults, and `@run driver jdk.test.lib.crac.CracTest` is used. The class name is omitted; it can be discovered through `test.file` system property. Regrettably I have to add the `@build MyTest` tag, though, because (even if I had it in `@run driver`) the test class would not be compiled. I've experimented with compiling myself, but had classpath issues (see CracTest.main for details).
-------------
PR: https://git.openjdk.org/crac/pull/50
More information about the crac-dev
mailing list