[crac] RFR: Add CRaC-specific tests to GHA [v5]

Radim Vansa duke at openjdk.org
Tue Mar 7 14:40:13 UTC 2023


On Tue, 7 Mar 2023 14:29:01 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with 16 additional commits since the last revision:
>> 
>>  - Finally fix ResolveTest
>>  - Add seemingly non-vital logs
>>  - Revert all debug info and hope for the best
>>  - what's wrong with cppath
>>  - Fix path
>>  - fix path
>>  - Fix criu SHA256
>>  - Print dump log
>>  - Use newer criu
>>  - Debug failing ResolveTest in GHA
>>  - ... and 6 more: https://git.openjdk.org/crac/compare/04996e37...1f9645ee
>
> test/jdk/jdk/crac/java/net/InetAddress/ResolveTest.java line 107:
> 
>> 105:         // is integrated.
>> 106:         List<String> javaCmd = new ArrayList<>();
>> 107:         javaCmd.addAll(Arrays.asList("/jdk/bin/java", "-cp", "/test-classes/", "-XX:CRaCCheckpointTo=/cr"));
> 
> This looks belonging to #50. Could this be the reason for strange failures of this test I've reported there?

Why would you think that? There's a different variant of this test in #50. This particular change, while correct, has no effect when we concatenate the list anyway, it's there only for clarity. I had to change the line when experimenting with `--init` version without the bash loop workaround.

-------------

PR: https://git.openjdk.org/crac/pull/48


More information about the crac-dev mailing list