[crac] RFR: Convert CRaC tests from shell scripts to Java [v3]

Radim Vansa duke at openjdk.org
Fri Mar 10 13:46:38 UTC 2023


On Wed, 8 Mar 2023 14:39:25 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove forgotten debugging command
>
> test/jdk/jdk/crac/JarFileFactoryCacheTest/JarFileFactoryCacheTest.java line 61:
> 
>> 59:             }
>> 60:             assert temp.toFile().delete();
>> 61:         }
> 
> Looks fine, although not very expected. The test is adjusted to generate the text file, so it is also deleted after the jar is generated.
> 
> A nit: probably `temp.resolve("test.txt")` worth to be computed once.

I am not sure what you tried to say in the first paragraph; is this a suggestion? Yes, I changed the code to get rid of extra resource file.

I'll put the resolved path to a var.

-------------

PR: https://git.openjdk.org/crac/pull/50


More information about the crac-dev mailing list