[crac] RFR: Fix ordering of invocation on Resources [v3]

[Radim Vansa]

On Fri, 28 Apr 2023 12:01:42 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - More fine-grained synchronization
>>  - Rework context ordering (round 2)
>>    
>>    * call afterRestore even if beforeCheckpoint throws
>>    * registering resource in previous/running context does not trigger exception immediatelly
>>    ** instead this will be one of the recorded exceptions and the resource has a chance to fire next time
>>    * we don't guarantee threads not deadlocking when trying to register a resource, though
>
> src/java.base/share/classes/jdk/crac/impl/AbstractContextImpl.java line 78:
> 
>> 76:     }
>> 77: 
>> 78:     protected abstract void runBeforeCheckpoint();
> 
> This is intended to be overwritten (becomes a part of the class interface). The intent behind the separate method is not evident. Corresponding runAfterRestore is private though.
> 
> After AbstractContexImpl has lost parameter P and comparator, a distinction between AbstractContexImpl and OrderedContext has been lost. Merging AbstractContexImpl into OrderedContext likely will provided clearer code.

ACI is implemented both by OrderedContext and PriorityContext, while PC is quite different from OC.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/60#discussion_r1182164379