[crac] RFR: Fix ordering of invocation on Resources [v3]

Radim Vansa duke at openjdk.org
Tue May 2 10:30:44 UTC 2023


On Tue, 2 May 2023 10:02:34 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> ACI is implemented both by OrderedContext and PriorityContext, while PC is quite different from OC.
>
> I'm trying to describe class hierachy and failing. The patch tries to reverse ACI-PC relation. ACI was for partially-ordered Resources (defined by a Comparator), and now it's for totally-ordered Resources (ordered by long). Trying to fit the partially-ordering PC as a subclass of the totally-ordering ACI feels unnatural. Can we have a cleaner hierachy of the classes?

No; ACI was totally-ordered in the previous version of the PR, but now it doesn't care about ordering at all; it's the abstract `runBeforeCheckpoint` that decides on the order.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/60#discussion_r1182370220


More information about the crac-dev mailing list