[crac] RFR: Support updating MANAGEABLE JVM options during restore [v2]

[Radim Vansa]

On Wed, 3 May 2023 10:03:40 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use RESTORE_SETTABLE on JVM flags
>>   
>>   * Fail early when using non settable flags
>>   * CracBuilder fix: don't use classpath during restore
>
> src/hotspot/share/runtime/globals.hpp line 2129:
> 
>> 2127:       "Throw CheckpointException if uncheckpointable resource handle found")\
>> 2128:                                                                             \
>> 2129:   product(bool, CRTrace, true, MANAGEABLE, "Minimal C/R tracing")           \
> 
> RESTORE_SETTABLE was meant here? Please don't mix in MANAGEABLE flags into this PR if that was inteded.

Looking for usages (actually only one) of the flag, it qualifies to be set at any time.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/61#discussion_r1183560669