[crac] RFR: Fix ordering of invocation on Resources [v6]

Radim Vansa duke at openjdk.org
Thu May 4 21:54:47 UTC 2023


On Thu, 4 May 2023 21:35:41 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> * keeps the original handling of exceptions: afterRestore is called even if beforeCheckpoint throws
>> * allows to register a resource in a context that did not start beforeCheckpoint invocations yet
>> * registering resource in previous/running context fails the checkpoint but does not trigger exception immediately
>>    * instead this will be one of the recorded exceptions and the resource has a chance to fire next time
>> * allowed registration of resources can be invoked from other thread without deadlock; illegal registration can deadlock, though
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated Global Context javadoc, removed semanticContext()

I've reworded Global Context javadoc, added forgotten javadoc to `recordException`, and replaced calling `semanticContext()` with inlined versions of the `invokeBeforeCheckpoint` and `invokeAfterRestore` methods.

All changes in this PR are related to contexts. I see little point in dosing doc changes individually; API changes are here to support actual implementation of the fix.

-------------

PR Comment: https://git.openjdk.org/crac/pull/60#issuecomment-1535456836


More information about the crac-dev mailing list