[crac] RFR: Fix ordering of invocation on Resources [v7]
Radim Vansa
duke at openjdk.org
Thu May 4 22:09:04 UTC 2023
On Thu, 4 May 2023 21:52:50 GMT, Radim Vansa <duke at openjdk.org> wrote:
>> * keeps the original handling of exceptions: afterRestore is called even if beforeCheckpoint throws
>> * allows to register a resource in a context that did not start beforeCheckpoint invocations yet
>> * registering resource in previous/running context fails the checkpoint but does not trigger exception immediately
>> * instead this will be one of the recorded exceptions and the resource has a chance to fire next time
>> * allowed registration of resources can be invoked from other thread without deadlock; illegal registration can deadlock, though
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Add the missing javadoc
There is one negligence in this PR and that is the lack of test for concurrent registration and notification in the JDK context. I've omitted that partly as this was happening reproducibly in the `newfd` branch, therefore I thought a synthetic test was not necessary. I could add it, though, to demonstrate the behaviour.
-------------
PR Comment: https://git.openjdk.org/crac/pull/60#issuecomment-1535468906
More information about the crac-dev
mailing list