[crac] RFR: Ensure all notifications finish even if only daemon threads remain [v4]

[Radim Vansa]

On Fri, 5 May 2023 15:57:32 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup
>
> src/java.base/share/classes/jdk/crac/Core.java line 287:
> 
>> 285:                     try {
>> 286:                         keepAlive = new KeepAlive();
>> 287:                     } catch (InterruptedException e) {
> 
> Upon catching InterruptedException you should set thread interrupted status.
> 
> Any reason to use RuntimeException than CheckpointException? (preferrably in a comment).

Also, if you're just rethrowing runtime exception you could move the try-catch into the class.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/62#discussion_r1186262728