[crac] RFR: Ensure all notifications finish even if only daemon threads remain [v4]

Radim Vansa duke at openjdk.org
Fri May 5 16:03:54 UTC 2023


On Thu, 4 May 2023 17:12:32 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> test/jdk/jdk/crac/DaemonAfterRestore.java line 82:
>> 
>>> 80:             System.out.println("worker thread finish");
>>> 81:         });
>>> 82:         workerThread.setDaemon(false);
>> 
>> Unnecessary, thread created from main thread (non-daemon) is not a daemon either.
>
> Otherwise there should be an assert, so it's more straightforward to set the mode.

I agree with the assert

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/62#discussion_r1186259922


More information about the crac-dev mailing list