[crac] RFR: Fix ordering of invocation on Resources [v10]

Radim Vansa duke at openjdk.org
Wed May 10 10:50:49 UTC 2023


On Wed, 10 May 2023 09:38:50 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> * keeps the original handling of exceptions: afterRestore is called even if beforeCheckpoint throws
>> * allows to register a resource in a context that did not start beforeCheckpoint invocations yet
>> * registering resource in previous/running context fails the checkpoint but does not trigger exception immediately
>>    * instead this will be one of the recorded exceptions and the resource has a chance to fire next time
>> * allowed registration of resources can be invoked from other thread without deadlock; illegal registration can deadlock, though
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove mention of single-threaded notifications

test/jdk/jdk/crac/ContextOrderTest.java line 54:

> 52:         System.setProperty("java.util.logging.config.file", Utils.TEST_SRC + "/logging.properties");
> 53: 
> 54: //        testOrder();

Oops, noticed this got commented out.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/60#discussion_r1189726828


More information about the crac-dev mailing list