[crac] RFR: Fix ordering of invocation on Resources [v10]

[Radim Vansa]

On Wed, 10 May 2023 13:10:24 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Yes; there's no way to remove already suppressed exceptions, and the message is too valuable to lose it. I could create an exception with the same message but without suppressed exceptions - then I'd lose its stack trace, though.
>> I don't see much issues in this duplication.
>
> It seems we should have allowed the message in the CheckpointException, to avoid this problem. The only place where CheckpointException with the message is called is recursive checkpoint detection from https://github.com/openjdk/crac/pull/6. 
> 
> OK for this PR.

That's not entirely true; CheckpointException is a public API and Resources can use it. In fact I find it quite natural to use for reporting any 'generic' error during checkpoint; if we want to limit usage to internal we need to make the constructors package-private constructors.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/60#discussion_r1189940797