[crac] RFR: Linux file system watcher support

Radim Vansa duke at openjdk.org
Tue May 16 08:33:17 UTC 2023


On Sun, 14 May 2023 10:00:26 GMT, joeylee <duke at openjdk.org> wrote:

> inotify monitors changes on filesystem, this support automatic restore for LinuxFileWatcher.
> 
> FileWatcherAfterRestoreTest verifies watcher service works after restore.
> FileWatcherTest verifies automatic closing inotiify fd
> 
> The watcher keys are still managed by user, so exception will be thrown if no watcher keys are leaked, as in FileWatcherWithOpenKeysTest

I was hoping that a fastdebug build with assertions on would fail somewhere earlier but it is not the case. I would suspect that since this NULL dereference is happening when the thread already exits there's an earlier event that goes wrong.

-------------

PR Comment: https://git.openjdk.org/crac/pull/72#issuecomment-1549229817


More information about the crac-dev mailing list