[crac] RFR: Linux file system watcher support [v2]

Radim Vansa duke at openjdk.org
Fri May 19 13:17:14 UTC 2023


On Wed, 17 May 2023 12:19:50 GMT, joeylee <duke at openjdk.org> wrote:

>> inotify monitors changes on filesystem, this support automatic restore for LinuxFileWatcher.
>> 
>> FileWatcherAfterRestoreTest verifies watcher service works after restore.
>> FileWatcherTest verifies automatic closing inotiify fd
>> 
>> The watcher keys are still managed by user, so exception will be thrown if no watcher keys are leaked, as in FileWatcherWithOpenKeysTest
>
> joeylee has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Linux file system watcher support

Thanks for fixing the nitpicks; I'll wait for the test that demonstrates code managing WatchKey with this concurrent checkpoint.

-------------

PR Review: https://git.openjdk.org/crac/pull/72#pullrequestreview-1434402460


More information about the crac-dev mailing list