[crac] RFR: Do not register MethodHandleNatives [v2]

[Radim Vansa]

On Thu, 25 May 2023 13:24:09 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> A simple solution for the lambda problem in the CRaC Core: do not register CALL_SITES at all.
>> 
>> A second part of the PR introduces an interface for Cleaner.register() with priority parameter.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java
>   
>   Co-authored-by: Dan Heidinga <heidinga at redhat.com>

LGTM, except the few typos and naming.

src/java.base/share/classes/java/lang/ref/Cleaner.java line 225:

> 223: 
> 224:     /**
> 225:      * Register an object and object and also register the underlying Reference with a CRaC priority.

an object and action

src/java.base/share/classes/jdk/internal/access/JavaLangRefAccess.java line 52:

> 50: 
> 51:     /**
> 52:      * Registers an object and an action in a cleaner, with action synhronized with a CRaC priority.

typo: `synhronized`

src/java.base/share/classes/jdk/internal/access/JavaLangRefAccess.java line 54:

> 52:      * Registers an object and an action in a cleaner, with action synhronized with a CRaC priority.
> 53:      */
> 54:     Cleaner.Cleanable register(Cleaner cleaner, Object obj, Runnable action, JDKResource.Priority priority);

The method should be probably called something like `registerCleanable`, or `createCleanable`, given that this is a package-wide access.

-------------

Marked as reviewed by rvansa at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/crac/pull/76#pullrequestreview-1444097256
PR Review Comment: https://git.openjdk.org/crac/pull/76#discussion_r1206312316
PR Review Comment: https://git.openjdk.org/crac/pull/76#discussion_r1205647804
PR Review Comment: https://git.openjdk.org/crac/pull/76#discussion_r1205651624