[crac] RFR: Introduce per-Priority Context with different policies [v2]

[Anton Kozlov]

On Thu, 18 May 2023 11:57:28 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits:
>> 
>>  - Merge remote-tracking branch 'a/crac/context-update' into context-update
>>  - Cleanup
>>  - Cleanup
>>  - Update
>>  - All done
>>  - Revert global Context
>>  - Final touches
>>  - Interrupt does not work
>>  - Update test
>>  - Merge remote-tracking branch 'jdk/crac/crac' into context-update
>>  - ... and 8 more: https://git.openjdk.org/crac/compare/cdf4c35d...5182ba92
>
> src/java.base/share/classes/jdk/crac/impl/CriticalUnorderedContext.java line 85:
> 
>> 83:                     invokeBeforeCheckpoint(resource);
>> 84:                 } catch (Exception e) {
>> 85:                     concurrentCheckpointException.handle(e);
> 
> I **really** dislike the fact that the exception is reported only during restore, which may never happen. The checkpoint should be marked for failure in here.

This makes sense. As a thought excercise, it is possible to have add a last Resource, that will query all pending exceptions in all previous contextes, or make this context block once all beforeCheckpoint are done and there is nowhere to report exceptions. Both are also possible for user contextes, outside of the system classes.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/74#discussion_r1209500968