[crac] RFR: Remove INCLUDE_LD_SO_LIST_DIAGNOSTICS [v5]

[Radim Vansa]

On Wed, 8 Nov 2023 15:14:09 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> It was introduced in glibc-2.34 together with preferred CPU_FEATURE_ACTIVE.
>
> Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - More simplifications after INCLUDE_LD_SO_LIST_DIAGNOSTICS removal
>  - Remove INCLUDE_LD_SO_LIST_DIAGNOSTICS
>     - it was introduced in glibc-2.34 together with preferred CPU_FEATURE_ACTIVE

src/hotspot/cpu/x86/vm_version_x86.cpp line 867:

> 865:     if (!INCLUDE_CPU_FEATURE_ACTIVE) {
> 866:       if (ShowCPUFeatures) {
> 867:         tty->print_cr("Environment variable already set, both glibc CPU_FEATURE_ACTIVE is unavailable - re-exec suppressed: " TUNABLES_NAME "=%s", env);

The "both" word is extra in here I guess.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/136#discussion_r1386785365