[crac] RFR: Fix Windows build of Decoder
Roman Marchenko
rmarchenko at openjdk.org
Thu Nov 16 07:45:14 UTC 2023
On Thu, 9 Nov 2023 12:06:16 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
> Fixes build failure on Windows introduced in https://github.com/openjdk/crac/pull/116
src/hotspot/share/utilities/decoder.hpp line 125:
> 123: static void print_state_on(outputStream* st);
> 124:
> 125: #ifdef _WINDOWS
I'm not sure we have to use #ifdef WINDOWS here.
There is src\hotspot\os\windows\decoder_windows.cpp file already, I beileve it should be there.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/138#discussion_r1395272539
More information about the crac-dev
mailing list