[crac] RFR: More robust classpath parsing [v2]
Roman Marchenko
rmarchenko at openjdk.org
Thu Nov 16 10:39:01 UTC 2023
On Thu, 16 Nov 2023 10:06:47 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> On Windows, path with forward slashes starting with `/` is an accepted classpath element, even though it might seem as invalid and parsing in `Path.of(...)` would fail.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Use File() ctor instead of custom parsing
src/java.base/share/classes/jdk/internal/crac/JDKFileResource.java line 28:
> 26: CLASSPATH_ENTRIES = new Path[items.length];
> 27: for (int i = 0; i < items.length; i++) {
> 28: // On Windows, path with forward slashes starting with '/' is an accepted classpath
With the latest change do you think this comment is still needed?
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/140#discussion_r1395495745
More information about the crac-dev
mailing list