[crac] RFR: Propagating CRaC event to JVMTI agents [v3]
Roman Marchenko
rmarchenko at openjdk.org
Thu Nov 23 15:06:39 UTC 2023
On Thu, 23 Nov 2023 10:05:49 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed test
>
> src/hotspot/share/prims/jvmtiUtil.hpp line 60:
>
>> 58: }
>> 59: if (num >= EXT_MIN_EVENT_TYPE_VAL && num <= EXT_MAX_EVENT_TYPE_VAL) {
>> 60: return (num != EXT_EVENT_CLASS_UNLOAD && num != EXT_EVENT_CRAC_BEFORE_CHECKPOINT && num != EXT_EVENT_CRAC_AFTER_RESTORE);
>
> Any idea why `EXT_EVENT_VIRTUAL_THREAD_MOUNT`/`UNMOUNT` are not listed here?
This function checks if an event is related to a particular thread. This is `true` only for `VIRTUAL_THREAD_MOUNT/UNMOUNT`. For both `EXT_EVENT_CLASS_UNLOAD` and for CRaC events it doesn't make sense - so `false` is returned.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/143#discussion_r1403498601
More information about the crac-dev
mailing list