[crac] RFR: Close files opened by Decoder before checkpoint

Anton Kozlov akozlov at openjdk.org
Mon Oct 2 17:55:12 UTC 2023

On Mon, 25 Sep 2023 13:08:24 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> Native memory tracking needs to resolve some addresses for stack unwinding and the decoders keep some shared library files open as a cache. Since the decoder instances can be re-allocated anytime this fix just destroys them before a checkpoint.

src/hotspot/share/utilities/decoder.cpp line 134:

> 132:     delete _error_handler_decoder;
> 133:     _error_handler_decoder = nullptr;
> 134:   }

Error handler appears only during fatal error reporting. We can drop the handling and syncing with the errorred thread, as fatal error will follow anyway after we find error handler. So this can be

guarantee(_error_handler_decoder == nullptr)


PR Review Comment: https://git.openjdk.org/crac/pull/116#discussion_r1342986789

More information about the crac-dev mailing list