[crac] RFR: Drop perfdata and cppath
Anton Kozlov
akozlov at openjdk.org
Mon Oct 2 17:57:29 UTC 2023
On Wed, 27 Sep 2023 20:40:53 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
> Storing PerfMemory contents into file might be fragile; if the file is corrupted (e.g. due to wrong permissions) JVM might receive SIGBUS when updating performance counters after restore.
> This commit provides alternate solution, moving the shared file-mapped memory into private anonymous memory during C/R.
test/jdk/jdk/crac/PerfMemoryRestoreTest.java line 66:
> 64: Thread.sleep(10);
> 65: }
> 66: // Note: we need to check the checkpoint.pid(), which should be restored (when using CRIU),
Could you also check that jcmd works after restore?
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/119#discussion_r1342988896
More information about the crac-dev
mailing list