[crac] RFR: CRaC: Fix fds opened for logging [v2]

Radim Vansa rvansa at openjdk.org
Tue Oct 3 07:11:55 UTC 2023

On Mon, 2 Oct 2023 14:56:01 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> CRaC: Fix fds opened for logging
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>  - AsyncLogWriter: add stop() and resume()
>  - Merge branch 'crac' into crac-logfd
>  - b229ea41: <no commit message found>
>  - 8f161825: <no commit message found>
>  - d8a454cb: <no commit message found>
>  - Merge branch 'crac' into crac-logfd
>  - +testcase
>  - CRaC: Fix fds opened for logging

About when to call them: IMO the more you do outside the VM thread the better. OpenJDK CRaC has gone the way where we perform most of the C/R handling in parallel with running the application, as opposed to the approach in OpenJ9 where even the Java callbacks (Resource.beforeCheckpoint/afterRestore) are performed in a single-threaded mode (which has its own advantage in a reduced need for complicated synchronization), so it is better to keep to philosophy consistent.


PR Comment: https://git.openjdk.org/crac/pull/113#issuecomment-1744311006

More information about the crac-dev mailing list