[crac] RFR: CRaC: Fix fds opened for logging [v6]

Jan Kratochvil jkratochvil at openjdk.org
Thu Oct 5 15:40:28 UTC 2023


On Thu, 5 Oct 2023 15:24:23 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> CRaC: Fix fds opened for logging
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Attempt to solve a compilation error from GHA:
>     /usr/bin/ld: build/linux-x64/hotspot/variant-zero/libjvm/objs/crac.o: in function `AsyncLogWriter::stop()':
>     src/hotspot/share/logging/logAsyncWriter.hpp:202: undefined reference to `PlatformMutex::lock()'
>     /usr/bin/ld: build/linux-x64/hotspot/variant-zero/libjvm/objs/crac.o: in function `AsyncLogWriter::resume()':
>     src/hotspot/share/logging/logAsyncWriter.hpp:203: undefined reference to `PlatformMutex::unlock()'
>     /usr/bin/ld: build/linux-x64/hotspot/variant-zero/libjvm/objs/crac.o: in function `AsyncLogWriter::stop()':
>     src/hotspot/share/logging/logAsyncWriter.hpp:202: undefined reference to `PlatformMutex::lock()'
>     /usr/bin/ld: build/linux-x64/hotspot/variant-zero/libjvm/objs/crac.o: in function `AsyncLogWriter::resume()':
>     src/hotspot/share/logging/logAsyncWriter.hpp:203: undefined reference to `PlatformMutex::unlock()'

Please do not sponsor it yet, maybe there is really some OSX compilation regression.

-------------

PR Comment: https://git.openjdk.org/crac/pull/113#issuecomment-1749153061


More information about the crac-dev mailing list