[crac] RFR: Drop perfdata and cppath [v7]
Alexey Bakhtin
abakhtin at openjdk.org
Fri Oct 20 18:22:00 UTC 2023
On Fri, 13 Oct 2023 15:39:35 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Storing PerfMemory contents into file might be fragile; if the file is corrupted (e.g. due to wrong permissions) JVM might receive SIGBUS when updating performance counters after restore.
>> This commit provides alternate solution, moving the shared file-mapped memory into private anonymous memory during C/R.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Use hardcoded path
src/hotspot/os/linux/perfMemory_linux.hpp line 33:
> 31:
> 32: public:
> 33: static bool checkpoint(const char* checkpoint_path);
With the proposed changes you do not need the `checkpoint_path` parameter anymore.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/119#discussion_r1367362790
More information about the crac-dev
mailing list