[crac] RFR: Put restored Java process on foreground instead of restorewait

Roman Marchenko rmarchenko at openjdk.org
Tue Oct 24 07:22:59 UTC 2023

On Mon, 23 Oct 2023 13:18:03 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> Solves a scenario where we restore the process in background, `fg` it and then try to Ctrl+C interrupt it. 
> The usefulness of this actually depends on https://github.com/CRaC/criu/pull/14
> `criuengine` restorewait does not have tty on stdin/stdout/stderr, though one FD is open to tty; we have to find it.

src/java.base/unix/native/criuengine/criuengine.c line 391:

> 389:         int fd = atoi(dp->d_name);
> 390:         if (isatty(fd)) {
> 391:             g_tty_fd = fd;

Shouldn't we break here?


PR Review Comment: https://git.openjdk.org/crac/pull/133#discussion_r1369722656

More information about the crac-dev mailing list