[crac] RFR: Compile all the INCLUDE_LD_SO_LIST_DIAGNOSTICS code unconditionally

[Jan Kratochvil]

On Tue, 31 Oct 2023 06:52:47 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Make INCLUDE_LD_SO_LIST_DIAGNOSTICS an `if` conditional instead of a `#if` one.
>> Fix compilation failures.
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 856:
> 
>> 854: }
>> 855: 
>> 856: //#if INCLUDE_LD_SO_LIST_DIAGNOSTICS
> 
> Please remove commented out code.

I wanted to indicate this function is used only for `INCLUDE_LD_SO_LIST_DIAGNOSTICS`. I can also put there a full sentence.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/136#discussion_r1377132708