[crac] RFR: Compile all the INCLUDE_LD_SO_LIST_DIAGNOSTICS code unconditionally [v2]

Jan Kratochvil jkratochvil at openjdk.org
Tue Oct 31 07:40:22 UTC 2023


> Make INCLUDE_LD_SO_LIST_DIAGNOSTICS an `if` conditional instead of a `#if` one.
> Fix compilation failures.

Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:

  Fix compilation errors during all the 3 configurations:
    #undef INCLUDE_CPU_FEATURE_ACTIVE
    #undef INCLUDE_LD_SO_LIST_DIAGNOSTICS
    #define INCLUDE_CPU_FEATURE_ACTIVE 0/1
    #define INCLUDE_LD_SO_LIST_DIAGNOSTICS 0/1
     - but never 1 for both

-------------

Changes:
  - all: https://git.openjdk.org/crac/pull/136/files
  - new: https://git.openjdk.org/crac/pull/136/files/0b4f6692..c1769a92

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=crac&pr=136&range=01
 - incr: https://webrevs.openjdk.org/?repo=crac&pr=136&range=00-01

  Stats: 69 lines in 2 files changed: 22 ins; 27 del; 20 mod
  Patch: https://git.openjdk.org/crac/pull/136.diff
  Fetch: git fetch https://git.openjdk.org/crac.git pull/136/head:pull/136

PR: https://git.openjdk.org/crac/pull/136


More information about the crac-dev mailing list