[crac] RFR: Wait until G1 GC has finished before creating a snapshot. [v8]
Jan Kratochvil
jkratochvil at openjdk.org
Fri Sep 1 13:48:13 UTC 2023
On Fri, 1 Sep 2023 11:06:24 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
> To be sure, have you tested the change in a debug build with asserts enabled?
I do run a simple Linux x86_64 snapshot+restore which does work. As the full regression test takes me 10 hours I just rely on GHA. But it is true I check GHA only very briefly for a massive failure. Few unexplainable failures are always there so I ignore them. In this case I see some crac x86 (32-bit) failures.
This situation is not good longterm. In the past GDB always had some failures in the testsuite and it was too much work to really fix them all so I was just making a diff between results. Should I/we spend the time to fix the failures or make some scripts for diffs of the results?
-------------
PR Comment: https://git.openjdk.org/crac/pull/93#issuecomment-1702774931
More information about the crac-dev
mailing list