[crac] RFR: Fix a #73 reference regression

Mon Sep 4 06:56:15 UTC 2023

On Sat, 2 Sep 2023 17:34:58 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> It fixes:
> - test/jdk/java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java
> - test/jdk/java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java
> - test/jdk/java/lang/ref/CleanerTest.java
> @rvansa the author of #73 should know more.

@jankratochvil Can you fill in some details? #73 uses an alternative `poll` method that returns immediately when someone calls `wakeupReferenceQueue`, otherwise the cleaner thread gets stuck for up to 60 seconds before checkpoint when the queue is empty. By reverting to `remove()` you're breaking this. Are these tests somehow causing spurious wakeups?

-------------

PR Comment: https://git.openjdk.org/crac/pull/108#issuecomment-1704711704