[crac] RFR: Fix ArchivedEnumTest.java testsuite regression
Jan Kratochvil
jkratochvil at openjdk.org
Mon Sep 4 12:02:49 UTC 2023
On Mon, 4 Sep 2023 07:08:15 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
> Given that the global context is created only once, I think it would be OK to drop the field and obtain the config value in runtime.
OK. It is not great to base code only on its current callers but I do not know about a better solution.
> However, I wonder if the option really works; looks like this PR is disabling only the error in the test, though the `[B]` option does not really fit (it does not end up as a compile-time-known deterministic value). Can you override this in runtime or would JDK always load the default value?
I was feeling the `[B]` is probably wrong but I did expect there will be some better private final static Java solution for the patch. So I did not find this `[B]` part important as it will get dropped anyway (which it got).
-------------
PR Comment: https://git.openjdk.org/crac/pull/109#issuecomment-1705142033
More information about the crac-dev
mailing list