[crac] RFR: Persist memory in-JVM
Anton Kozlov
akozlov at openjdk.org
Fri Sep 8 10:04:18 UTC 2023
On Tue, 5 Sep 2023 07:03:42 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
> I have no issues with restoring the memory just from the info in MemoryLoader
👍
> We would need to allocate a new memory, get into impl details of the bitmap (`_committed._map`) etc.; I wouldn't do it in release mode for sure. Given the complexity the check seems as an overkill.
Hmm, that indeed does not look nice. Thinking about alternatives, we may have a boolean flag set to true during checkpoints only, and check the flag during operations with _committed, asserting accidental change. I agree that the checks should be pretty cheap in production and easy to implement.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/95#discussion_r1319650962
More information about the crac-dev
mailing list