[crac] RFR: CRaC: Fix fds opened for logging

[Radim Vansa]

On Tue, 19 Sep 2023 14:30:15 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> CRaC: Fix fds opened for logging

Sorry, I misunderstood the issue. I though that the gc log is causing trouble during checkpoint, but in fact the log is opened before `close_extra_descriptors` and this method mistakes it for accidentally inherited FD, and closes it. With your fix, the FD is marked as inherited and ignored during CRaC FD checks; CRIU seems to restore the open file correctly.

I think that the fix would be completely fine had we considered CRIU as the only C/R implementation, but we would need to deal with reopening this in minicriu. Therefore, unless you find the implementation difficult, I would opt for close/reopen implementation.

-------------

PR Comment: https://git.openjdk.org/crac/pull/113#issuecomment-1733480499