[crac] RFR: Fix OSX x86_64 CRaC crash

Radim Vansa rvansa at openjdk.org
Fri Sep 29 11:11:30 UTC 2023


On Fri, 29 Sep 2023 10:12:50 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> - copy-paste the same code from src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
> 
> It has fixed 3 testcases but the last 4th failure looks to be unrelated to this problem.
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR
>    jtreg:test/jdk/jdk/crac/JarFileFactoryCacheTest/JarFileFactoryCacheTest.java
>                                                          1     1     0     0
>    jtreg:test/jdk/jdk/crac/MXBean.java                   1     1     0     0
>    jtreg:test/jdk/jdk/crac/RefQueueTest.java             1     1     0     0
>    jtreg:test/jdk/jdk/crac/recursiveCheckpoint/Test.java
>>>                                                       1     0     1     0 <<
> ==============================

A little nitpick: could you use `nullptr` in both locations rather than `NULL`?

-------------

PR Comment: https://git.openjdk.org/crac/pull/121#issuecomment-1740718782


More information about the crac-dev mailing list