[crac] RFR: 8346178: [CRaC] Failure in com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java

[Radim Vansa]

On Fri, 13 Dec 2024 15:08:14 GMT, Timofei Pushkin <duke at openjdk.org> wrote:

> The test takes all dcmd commands and invokes each to check if a command exceeds permissions set up in the test.
> 
> This fix simply excludes `jdk.checkpoint` command from the test and keeps the rest of the test logic untouched. This approach was chosen because (1) checkpointing requires many permissions and it would be better to create a separate test for this if we want to "document" these permissions since the current test does not separate permission sets by commands, (2) the test would need additional adjustments to actually perform a checkpoint due to the CRaC specifics.

I agree with the failure analysis, LGTM. Hopefully we'll merge latest JDK changes soon (in another PR). Thanks!

-------------

Marked as reviewed by rvansa (Committer).

PR Review: https://git.openjdk.org/crac/pull/161#pullrequestreview-2508605091