[crac] RFR: 8346386: [CRaC] Move CRaC’s Java code out of restricted packages

Radim Vansa rvansa at openjdk.org
Tue Dec 17 13:23:21 UTC 2024


On Tue, 17 Dec 2024 12:36:04 GMT, Timofei Pushkin <duke at openjdk.org> wrote:

> To circumvent CRaC's limiting not-yet-standardized status:
> 1. Moved CRaC interface from `javax.crac` in `java.base` to `jdk.crac` in a new `jdk.crac` module.
> 2. Moved CRaC implementation from `jdk.crac` to `jdk.internal.crac.mirror`, both inside `java.base`. The whole CRaC implementation now resides in `jdk.internal.crac` which is exported (partially) only to the new `jdk.crac` module.

src/java.base/share/classes/java/lang/System.java line 836:

> 834:      *
> 835:      * @crac System properties can be updated on restore from a checkpoint.
> 836:      * The application can {@link jdk.internal.crac.mirror.Context#register(jdk.internal.crac.mirror.Resource) register}

The docs should use the `jdk.crac` package; `jdk.internal.crac.mirror` should not be used from application. Could you check that the generated javadocs will then link correctly to the different module?

src/java.base/share/classes/jdk/internal/crac/mirror/impl/BlockingOrderedContext.java line 1:

> 1: package jdk.internal.crac.mirror.impl;

Looks like this class doesn't have a proper license header. Maybe better fill that in another PR, though...

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/164#discussion_r1888497510
PR Review Comment: https://git.openjdk.org/crac/pull/164#discussion_r1888503724


More information about the crac-dev mailing list