[crac] RFR: Ignore errors parsing classpath [v2]

Radim Vansa rvansa at openjdk.org
Fri Feb 16 12:31:26 UTC 2024


On Tue, 6 Feb 2024 09:41:37 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/crac/JDKFileResource.java line 34:
>> 
>>> 32:             } catch (Exception e) {
>>> 33:                 // Ignore any exception parsing the path: URLClassPath.toFileURL() ignores IOExceptions
>>> 34:                 // as well, here we might get InvalidPathException
>> 
>> I think `CLASSPATH_ENTRIES[i]` will remain `null` in such case and later code in this file accesses it without a `null` check. But I haven't tried to reproduce it on Windows.
>
> Correct, I need to push an update to this.

Updated, with improved test.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/149#discussion_r1492392354


More information about the crac-dev mailing list