[crac] RFR: 8328344: [CRaC] Avoid error when running with -XX:+PerfDisableSharedMem [v3]

Radim Vansa rvansa at openjdk.org
Fri Mar 22 13:59:55 UTC 2024

On Tue, 19 Mar 2024 19:53:01 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> CRaC tries to unconditionally restore the hsperf file, even if the checkpointed JVM process was started with `-XX:+PerfDisableSharedMem`.
>> The fix is trivial: check for the existence of the hsperf file in `PerfMemoryLinux::restore()` just as we already do it in `PerfMemoryLinux::checkpoint()`.
> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>   Don't busy wait for the appearance of the hs_perf file if running with -XX:+PerfDisableSharedMem

@AntonKozlov I've replaced the 2x 10 second wait with 2x 100 ms - could you review please to give it a third pair of eyes?


PR Comment: https://git.openjdk.org/crac/pull/153#issuecomment-2015163565

More information about the crac-dev mailing list