[crac] RFR: 8328344: [CRaC] Avoid error when running with -XX:+PerfDisableSharedMem [v4]

Radim Vansa rvansa at openjdk.org
Tue Mar 26 08:04:02 UTC 2024

On Fri, 22 Mar 2024 16:45:11 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>>   Don't wait 2x10 seconds when with -XX:+PerfDisableSharedMem
> test/jdk/jdk/crac/PerfMemoryRestoreTest.java line 68:
>> 66:         Path perfdata = Path.of("/tmp", "hsperfdata_" + System.getProperty("user.name"), pid);
>> 67:         if (perfDisableSharedMem) {
>> 68:             Thread.sleep(100);
> I like the refactoring and that we can control this delay independently. 
> Nit-picking: should not be this a named constant? And does 100ms has any reason behind, or can it be 1sec (a little bit safer)?

Extracted to constant.

My expert opinion says that the almost arbitrary choice of 100 ms is super good enough.


PR Review Comment: https://git.openjdk.org/crac/pull/153#discussion_r1538737997

More information about the crac-dev mailing list