[crac] RFR: GLIBC->CPU flags optimization [v2]

Radim Vansa rvansa at openjdk.org
Wed Mar 27 08:47:50 UTC 2024


On Wed, 27 Mar 2024 08:39:01 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> Reduce the number of `GLIBC_*` flags when it can use existing `CPU_*` flags.
>> This patch was split out of PR #136.
>> 
>> 
>>  2 files changed, 9 insertions(+), 17 deletions(-)
>> 
>> So I find it clearly an improvement.
>> As an explanation: I created the GLIBC_* namespace in addition to the existing upstream CPU_* namespace. And some my additions in GLIBC_* namespace have now appeared by https://github.com/openjdk/jdk/commit/d50b6eb342e9ec96d1a01dafc317e00725dc84c0 also in the upstream CPU_* namespace. They were missing in the CPU_* namespace when I was implementing it. So we can remove the duplicity from GLIBC_* namespace.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'crac' into crac-glibccpureduction
>  - GLIBC->CPU flags optimization

Marked as reviewed by rvansa (Committer).

-------------

PR Review: https://git.openjdk.org/crac/pull/139#pullrequestreview-1962650373


More information about the crac-dev mailing list