[crac] Integrated: 8352413: [CRaC] crexec fails to pass some options when CRAC_CRIU_OPTS is already used
Timofei Pushkin
tpushkin at openjdk.org
Wed Apr 2 14:00:26 UTC 2025
On Wed, 19 Mar 2025 12:04:49 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
> ~~This contains the change from #216 so that should be merged first.~~ UPD: rebased.
>
> The fix itself is small but coming up with a way to test it was not trivial:
> 1. I've split `jdk/crac/CracEngineOptionsTest.java` onto `jdk/crac/engineOptions/ParsingTest.java` and `jdk/crac/engineOptions/HelpTest.java` because it was getting too large (nothing added/removed, just split).
> 2. Added `jdk/crac/engineOptions/CracCriuOptsTest.java` to regression-test the main fix of this PR (this test depends on #216).
> 3. Removed a part that tested that `args` are actually applied by `crexec` from `jdk/crac/VMOptionsTest.java` because (2) is now effectively tests this (`VMOptionsTest` wasn't a proper place for this to begin with, it just was convenient).
This pull request has now been integrated.
Changeset: f1aa8900
Author: Timofei Pushkin <tpushkin at openjdk.org>
Committer: Radim Vansa <rvansa at openjdk.org>
URL: https://git.openjdk.org/crac/commit/f1aa890020af46ae8903a58de68b475f34c53576
Stats: 601 lines in 6 files changed: 364 ins; 232 del; 5 mod
8352413: [CRaC] crexec fails to pass some options when CRAC_CRIU_OPTS is already used
Reviewed-by: rvansa
-------------
PR: https://git.openjdk.org/crac/pull/217
More information about the crac-dev
mailing list