[crac] RFR: 8354679: [CRaC] jdk.crac.management makes JdkManagementCheckSince fail

Timofei Pushkin tpushkin at openjdk.org
Wed Apr 16 13:19:58 UTC 2025


Fixes the failing test, for simplicity pretending that both `jdk.crac` and `jdk.management/jdk.crac.management` were added in JDK 24 and before that there was no CRaC in the JDK. Otherwise we would need to retroactively generate symbols for JDKs 17–23 which is a decent amount of work (there are no public CRaC builds for some of these versions).

JDK 24 symbols were updated this way:
1. Create a custom build from the last OpenJDK 24 CRaC commit 884d0746b168550f13bdc687b1d96d468aec4411 (the last commit before JDK 25 was merged).
2. Update the symbols from that build using `make/scripts/generate-symbol-data.sh`.
3. Manually remove the CRaC methods removed in d64fb30c0874d93c986ad04ac3995a727b7a1ac8 from the symbols.

Also adds the since-checking tests to CI.

I initially wanted to also add a since-checking test for `jdk.crac` module but `SinceChecker` seems to have a bug which makes the test fail with “module: jdk.crac: `@since` version is 24 but the element exists before JDK 10”. I believe this is a `SinceChecker` bug because the same happens for other modules added after JDK 9 without a legacy preview, e.g. `jdk.graal.compiler`.

-------------

Commit messages:
 - Fix since checker test

Changes: https://git.openjdk.org/crac/pull/225/files
  Webrev: https://webrevs.openjdk.org/?repo=crac&pr=225&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8354679
  Stats: 80 lines in 7 files changed: 75 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/crac/pull/225.diff
  Fetch: git fetch https://git.openjdk.org/crac.git pull/225/head:pull/225

PR: https://git.openjdk.org/crac/pull/225


More information about the crac-dev mailing list