[crac] RFR: Merge jdk:jdk-25+3 [v2]

Dmitry Cherepanov dcherepanov at openjdk.org
Wed Apr 23 07:17:00 UTC 2025


On Tue, 22 Apr 2025 20:34:24 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> The changes seem to be applied correctly. I wonder though, whether should we upstream our changes to those listeners (refactoring) to synchronize with JDK and not have to deal with conflicts all the time. However we would still run into trouble during backports, as we would like to have CRaC changes synchronized across JDK majors (or not, if we don't expect further development in the Attach Listeners?)

Agree that it's better to upstream our changes. I'll follow up on it. I hope that upstreaming work shouldn't block the merge.

> src/hotspot/os/posix/posixAttachOperation.hpp line 91:
> 
>> 89:   bool is_effectively_completed()                      { return _effectively_completed; }
>> 90: 
>> 91:   int socket() {
> 
> the method should be `const`

Fixed, thanks.

-------------

PR Comment: https://git.openjdk.org/crac/pull/224#issuecomment-2823291185
PR Review Comment: https://git.openjdk.org/crac/pull/224#discussion_r2055400176


More information about the crac-dev mailing list