[crac] RFR: Move CPUFeatures verification to the parent process of JVM [v2]

[Jan Kratochvil]

On Tue, 29 Apr 2025 09:34:29 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Print load_user_data error
>>  - Rename userdata_name
>>  - Use the standardized prepare_user_data_api() style
>>  - Removed unused declaration
>
> src/hotspot/share/runtime/threads.cpp line 481:
> 
>> 479:   // Output stream module should be already initialized for error reporting during restore.
>> 480:   // JDK version should also be intialized for arguments parsing.
>> 481:   if (check_for_restore(args) != JNI_OK) return JNI_ERR;
> 
> Now we do almost the same thing twice on restore: here  we parse the args and check whether they are restore-settable, and then in `Arguments::parse` below we parse the args again. I'm not sure if it breaks anything (`Arguments::parse` may do the parsing a bit differently and overwrite some values with different results). If not, it's worth to at least add a TODO here to clean this up in the future.

It could be somehow cleaned up. But it is not so simple. Filed a TODO item internally as ZULU-75247.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2066889460