[crac] RFR: [CRaC] Support checkpointing with --patch-module by treating patch JARs as persistent

[Radim Vansa]

On Tue, 22 Jul 2025 08:37:48 GMT, mazhen <duke at openjdk.org> wrote:

>>> Great work, let's just sort out the OCA and enable running the testsuite in your repo.
>>> 
>>> Btw. the test could work using just `simengine` (there's nothing engine-specific and that would let us run on other platforms than only Linux) but it's OK to keep this on a real engine (CRIU).
>> 
>> Hi @rvansa ,
>> 
>> Thanks for the review and the green light on the changes! 
>> 
>> That's a great point about using simengine for broader platform compatibility. My reasoning for choosing the criu engine was specifically to test a true physical restore. A goal here is to verify that the module patch remains effective after the process's native state has been completely dumped and then reloaded by CRIU.
>> 
>> Since you mentioned it's okay to keep it, I'd prefer to stick with criu for this test to ensure that comprehensive validation.
>
>> Great work, let's just sort out the OCA and enable running the testsuite in your repo.
>> 
>> Btw. the test could work using just `simengine` (there's nothing engine-specific and that would let us run on other platforms than only Linux) but it's OK to keep this on a real engine (CRIU).
> 
> Hi @rvansa , 
> 
> a quick follow-up on the OCA status. I've been waiting for approval for over a month and it seems to be stalled.  Would you have any advice or be able to help nudge the process internally? Any help would be a huge boost. Thanks!

@mz1999 OCA is handled by Oracle, so we don't really have such internal connection. When I was requesting the approval it also took a while and I had to ping `opensource_ww_grp at oracle.com` asking them to check on the request. Are you requesting individual OCA or with company? In the latter case they request official approval that you can contribute to OSS.

@mz1999 Hi, any luck getting a response from Oracle?

-------------

PR Comment: https://git.openjdk.org/crac/pull/241#issuecomment-3104599922
PR Comment: https://git.openjdk.org/crac/pull/241#issuecomment-3129914781