[crac] RFR: 8364538: [CRaC] Test CRaCIgnoreRestoreIfUnavailable [v2]
Timofei Pushkin
tpushkin at openjdk.org
Tue Aug 5 07:17:19 UTC 2025
On Tue, 5 Aug 2025 06:48:00 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> test/jdk/jdk/crac/ignoreRestore/EngineFailureTest.java line 51:
>>
>>> 49: // Create an empty image which will pass VM's own checks. It may contain
>>> 50: // CPU features, for example.
>>> 51: new CracBuilder().engine(CracEngine.SIMULATE)
>>
>> OK, this creates the empty directory (or rather one with just features), but what's the point? Just making the 'restore' below fail at a different point of time? If there are two ways of failure, both should be tested.
>
> Yes, if there are no CPU features — that is a different failure.
>
> Did not want to add a test for that because I am not testing CPU features in this PR, but this particular one should not be hard to implement so I'll add it.
Added `NoCPUFeaturesTest`
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/255#discussion_r2253364580
More information about the crac-dev
mailing list