[crac] RFR: 8364538: [CRaC] Test CRaCIgnoreRestoreIfUnavailable [v2]
Radim Vansa
rvansa at openjdk.org
Wed Aug 6 15:42:27 UTC 2025
On Tue, 5 Aug 2025 13:06:21 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Could we use `-XX:CRaCEngineOptions=fail-with=unknown-option` instead? Or even `-XX:CRaCEngine=non-existent`?
>
> No, these are both VM-side failures, I could add tests for those but they are all currently handled in the same way w.r.t. `CRaCIgnoreRestoreIfUnavailable` so I don't see a point.
>
> This test is supposed to check a failure that is detected inside the `CRaCEngine::restore()` call, inside the engine library, and makes the call return.
OK, if you're saying there's no better way let's keep it as is.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/255#discussion_r2257590850
More information about the crac-dev
mailing list